aneoconsulting / ArmoniK.Extensions.Csharp

C# wrapper that provides high level interfaces to submit tasks to ArmoniK and a prebuilt worker that supports dynamic library loading
https://aneoconsulting.github.io/ArmoniK.Extensions.Csharp/
Apache License 2.0
7 stars 8 forks source link

Issue with retry - dot not work properly #218

Closed AntonyCanut closed 1 year ago

AntonyCanut commented 1 year ago

Hello,

We notice a problem about retry when a exception throw in a code. In this following line, this "task delay" do not work.

https://github.com/aneoconsulting/ArmoniK.Extensions.Csharp/blob/b0044a3e49769ea3a94f9c2201c9cb4581d7bc43/Client/src/Unified/Services/Submitter/Service.cs#L221C40-L221C40

Maybe you should use a "thread.sleep" or "wait" to fix this line.

Also, 5 seconds(retry) it's maybe too short. It's possible to configure this option ?


By the way, the counter start a 0 and show messages like : "0/5, 1/5, 2/5, 3/5, End". It's disturbing when we read the logs.

dbrasseur-aneo commented 1 year ago

Hello,

Thank you for your report, we'll investigate the issue and propose a fix ASAP. The fix will be available in 0.11.3 and 0.12.3 releases.

Best regards

dbrasseur-aneo commented 1 year ago

Fixed in #219