Properly manage cancellation token registering of logs in task creation (and anywhere else it is used)

aneoconsulting / ArmoniK

Main repository for ArmoniK, An Open-Source orchestrator based on Kubernetes managing the distribution of hybrid multi cloud computations

https://aneoconsulting.github.io/ArmoniK/

Apache License 2.0

25 stars 16 forks source link

Properly manage cancellation token registering of logs in task creation (and anywhere else it is used) #1056

Open aneojgurhem opened 1 year ago

aneojgurhem commented 1 year ago

          I think this could be problematic in a long running process as I think the cancellation token given to this function in always the same, so the register might be called multiple times on the same cancellation token. Should we unregister this callback at some point?

This should probably be done in another PR anyway.

_Originally posted by @lemaitre-aneo in https://github.com/aneoconsulting/ArmoniK.Core/pull/333#discussion_r1184602299_

lemaitre-aneo commented 1 year ago

Maybe it is the cause of the "CPU Leak" #231