search

aneonex / BitcoinChecker

Bitcoin Checker data module (v2)
MIT License
67 stars 23 forks source link

Any chance of adding CoinGecko? (support DEX) #78

Open gosuto-inzasheru opened 3 years ago

gosuto-inzasheru commented 3 years ago

Quite a nice API available here: https://www.coingecko.com/en/api.

aneonex commented 3 years ago

Why do you need CoinGecko? Bitcoin Checker app interacts directly with exchanges API, but CoinGecko is not an exchange but a centralized aggregator. Direct communication has various advantages: speed, availability, reliability, the ability to use the specifics of exchanges, and more.

gosuto-inzasheru commented 3 years ago

Because it will add instant support for all coins listed there, including a lot of DEX. I saw you added Uniswap but there are uncountable other DEXes each with their own coins.

I'm not sure about alternatives, I know there is thegraph.com but it is also still missing a lot of exchanges.

Interesting problem, I'd be curious about other techniques/APIs of extracting price information from LPs for example! More and more of trading will take on-chain only.

aneonex commented 3 years ago

I agree, CoinGecko is very useful for extracting price information from DEX. But when I added Uniswap, CoinGeko was missing information on some significant tokens, and there were other problems, so I had to use a more complex but reliable TheGraph. Perhaps the situation has improved now.

It seems like a good idea to implement support for top 20-30 DEX through CoinGecko. Will this solve the issue? Full integration with CoinGecko doesn't fit into the app's concept.

Interesting problem, I'd be curious about other techniques/APIs of extracting price information from LPs for example! More and more of trading will take on-chain only.

Yes it's true. But what is "LPs"? :)

gosuto-inzasheru commented 3 years ago

Liquidity pools. Problem is they don't use order books so price information is much more opaque. I find CoinGecko is somewhat of a solution here. This is their list of top DEXes: https://www.coingecko.com/en/dex.

mbenatti commented 3 years ago

:+1: for this! Will be awesome to have top 10/20/30 dex from coingecko on BitcoinChecker In my point of view LPs get out of the context of the APP, because the interface expect a pair(ex: BTC/BUSD) For LPs we need to have a more explicit way to show this (as example, is often called BTC/BUSD LP) An idea is to support the coins pair for these DEX on coingecko and put the LP on backlog for later

aneonex commented 3 years ago

@jorijnsmit Unfortunately, I was unable to find an API to get ticker for coin pair. CoinGecko only allows you to get a list of prices for a token, not for a pair. This leads to traffic overhead. Instead of CoinGecko , I plan to use a TheGraph.com for all DEX, as already implemented for Uniswap.

mbenatti commented 3 years ago

@jorijnsmit Unfortunately, I was unable to find an API to get ticker for coin pair. CoinGecko only allows you to get a list of prices for a token, not for a pair. This leads to traffic overhead. Instead of CoinGecko , I plan to use a TheGraph.com for all DEX, as already implemented for Uniswap.

any plans to have thegraph working?

aneonex commented 2 years ago

This turned out to be more difficult than I expected and will take longer, sorry. While the issue on hold.

terrorist96 commented 2 years ago

@aneonex could you add pancakeswap similar to how you added uniswap in the meantime?