anergictcell / hpo

Rust library for the Human Phenotype Ontology
6 stars 1 forks source link

Derive Debug more often? #37

Closed holtgrewe closed 1 year ago

holtgrewe commented 1 year ago

Thank you for this useful and great library.

What about introducing a #[derive(Debug)] in more places? For example, in Builtins, this would allow for serde deserialization with a custom deserializer.

anergictcell commented 1 year ago

Hi, thanks for the feedback. Definitely something I can and will do. It's easy to add and makes total sense. I had no idea the Debug trait is needed for Serde, but good to know and keep in mind. Feel free to open a PR if you need this urgently, I don't know when I'll be able to add it myself

anergictcell commented 1 year ago

Thanks a lot for the improvement!