Taimen support

[deeproot2k]

The execute-all.sh script runs and completes successfully. When I put the vender overlays in the aosp branch for taimen it builds fine but will not boot. I am prob doing something wrong on my end.

[deeproot2k]

I dont really want to merge this I just wanted so see if you could point me in a direction to fix my issues.

[anestisb]

The generated config files were not picked-up since the names were not matching the taimen included resources. Unfortunately Google does not keep the same naming conventions across the border. And the fact that the skipped one Pixel 2 device (muskie) complicated a few bits.

Try applying the changes and make a fresh build. Don't forget to include in the AOSP tree both the vendor and and vendor_overlay directories that are generated by the script.

[anestisb]

Btw changing the tittle to "taimen support" (or something similar) might help others that have an available device (I don't) to jump in and help testing / debugging.

[deeproot2k]

rebuilt. added vendor / vendor_overlay to my AOSP tree and its working. Google enrollment complains during reboots but all google apps I built seem fine even play store.

[anestisb]

That's great news. Thanks for taking the time to contribute your patches. Will review them the next few days and merge them. If you face any issues while running against a device consider opening a new issue.

[Bajasur]

Hi any idea what this error is? I get this error when running execute-all.sh

Thanks for any help

Bajasur: [] Extracting '/tmp/android_prepare_vendor.jlQiR6/taimen/opm1.171019.011/taimen-opm1.171019.011-factory-2df1c1cb.zip' [] Unzipping 'image-taimen-opm1.171019.011.zip' [-] Symlinks have not been properly processed from /tmp/android_img_extract.FRWAOM/taimen-opm1.171019.011-factory-2df1c1cb/images/vendor.img.raw [!] If you don't have a compatible debugfs version, modify 'execute-all.sh' to disable 'USE_DEBUGFS' flag [-] Factory images data extract failed mike@mike-XPS-15-9560 ~/Desktop/android-prepare-vendor $

[deeproot2k]

you either dont have debugfs installed or you dont have access to it with that user. What OS

[Bajasur]

Linux MInt 18.3. mike@mike-XPS-15-9560 ~ $ debugfs debugfs 1.42.13 (17-May-2015)

I definitely have debugfs installed. I am going to try running the script as root

[deeproot2k]

Im on debian stretch and I had to change some settings to have my local user access it. I have debugfs 1.43.4

[anestisb]

@Bajasur check https://github.com/anestisb/android-prepare-vendor/issues/114 regarding your issue.

[anestisb]

@deeproot2k have you found a Google Apps installation package that is stable enough for testing with Android 8.0 & 8.1? If so, which one?

The last time I've tried (a few weeks back) with Open GApps, they were behaving poorly.

[deeproot2k]

For the pixel and pixel 2 I have found that I ended gapps do not work well as installable packages and I have had better luck building them inline with my aosp using this guide. https://github.com/opengapps/aosp_build/blob/master/README.md I currently am using this method and have no problems. I have a fresh build running with open gapps with no issues yet

[prurigro]

I can confirm that this works like a charm with the latest taimen image OPM2.171019.012 (including with working mobile data, compared to the driver binaries packages provided by google).

Thanks for putting the energy into getting this working deeproot2k!

[Bajasur]

I hate to bug about this again, but anyone on Linux Mint cannot use this script without major edits. I was hoping someone can explain in detail how to revert the debugfs commits and use fuse instead.

Thanks and I apologize

[anestisb]

@Bajasur

diff --git a/execute-all.sh b/execute-all.sh
index 88106c3..9c383b2 100755
--- a/execute-all.sh
+++ b/execute-all.sh
@@ -321,9 +321,9 @@ if isDarwin; then
   _UMOUNT=umount
 else
   # For Linux use debugfs
-  USE_DEBUGFS=true
-  # SYS_TOOLS+=("fusermount")
-  # _UMOUNT="fusermount -u"
+  # USE_DEBUGFS=true
+  SYS_TOOLS+=("fusermount")
+  _UMOUNT="fusermount -u"
 fi

 # Check that system tools exist

[Bajasur]

Thanks @anestisb

If this works properly is the vendor overlay folder supposed to populate?

I was able to get it working using your edits. The script is running now

[anestisb]

Currently there are no overlays configured for the taimen setup, so the directory is expected to be empty.