Closed mydongistiny closed 6 years ago
Thanks for reporting the issue. Will check the naming bug you mention. Most probably I regressed something when refactoring the configurations logic.
Regarding the numbering suffix check the following commits:
The short story is that Pixel 2 factory images have a certain set of symbolic links where the basename of the src - dst pair is identical thus creating conflicts. So I've placed the number suffix counter as a simple workaround while also presenting a diff friendly logic with the old format.
Should be fixed now.
The naming problem is solved. The numbers are still there for some of the symlinks, but obviously you know that. Thanks for the quick reply.
Yeah the number suffixes will remain for all generated symlink targets since it's required by the Pixel 2 devices to avoid conflicts.
When generating marlin full config using latest source it makes a makefile named device-vendor-sailfish.mk instead of device-vendor-marlin.mk. Also the symlink names are now:
Standalone symbolic links
PRODUCT_PACKAGES += \ wcd9320_anc.binwcd9320_anc.bin0 \ wcd9320_mad_audio.binwcd9320_mad_audio.bin1 \ mbhc.binwcd9320_mbhc.bin2 \ toybox_vendoracpi3 \ toybox_vendorbase644 \ toybox_vendorbasename5 \ toybox_vendorblockdev6 \ toybox_vendorcal7 \ toybox_vendorcat8 \ toybox_vendorchcon9 \ toybox_vendorchgrp10 \ toybox_vendorchmod11 \ toybox_vendorchown12 \ toybox_vendorchroot13 \ toybox_vendorchrt14 \ toybox_vendorcksum15 \ toybox_vendorclear16 \
Not sure if the numbers are supposed to be there now as they weren't before.
https://hastebin.com/vuyuzulecu.pas - output of running execute-all https://hastebin.com/lonihewalu.tex - list of numbered symlinks