search

anestisb / android-prepare-vendor

Set of scripts to automate AOSP compatible vendor blobs generation from factory images
347 stars 156 forks source link

Script could fail earlier if ext4fuse is missing #133

Closed kuleszdl closed 5 years ago

kuleszdl commented 5 years ago

First of all, many thanks for making the useful scripts available!

I noticed a minor issue: The script does not check whether ext4fuse is available before extracting starts but fails afterwards:

    ...

[*] Using ext4fuse for image mounts
[*] Extracting '/android/android-prepare-vendor/x/sailfish/ppr2.180905.006/sailfish-ppr2.180905.006-factory-bad3cb18.zip'
[*] Unzipping 'image-sailfish-ppr2.180905.006.zip'
[-] '/tmp/android_img_extract.kU5l1f/sailfish-ppr2.180905.006-factory-bad3cb18/images/system.img.raw' mount failed
/android/android-prepare-vendor/scripts/extract-factory-images.sh: Zeile 129: ext4fuse: Kommando nicht gefunden.
[-] Factory images data extract failed

This could be enhanced by checking for the presense of the ext4fuse binary earlier, because after installting ext4fuse the unzip process needs to be re-run.

anestisb commented 5 years ago

Xmm weird, it should be already handled in https://github.com/anestisb/android-prepare-vendor/blob/master/scripts/extract-factory-images.sh#L258

Are you running in macOS or Linux host?

kuleszdl commented 5 years ago

I am running on a Linux host.

anestisb commented 5 years ago

Ok found it. Should be fixed in https://github.com/anestisb/android-prepare-vendor/commit/9b2c17ee35a505240c5befdba5b8b98a262b791e. Switching languages within the same project results to bad patterns :)

Thanks for reporting.

kuleszdl commented 5 years ago

Cool, many thanks!