search

anestisb / android-prepare-vendor

Set of scripts to automate AOSP compatible vendor blobs generation from factory images
347 stars 156 forks source link

blueline (Pixel 3) ends up with board=crosshatch in android-info.txt #141

Closed thestinger closed 5 years ago

thestinger commented 5 years ago

This prevents the generated flashing factory images since it checks this when flashing the image zip. It's happening because there's only a shared BoardConfigVendor.mk using vendor/google_devices/crosshatch/vendor-board-info.txt as the source of information. Nothing uses the generated vendor/google_devices/blueline/vendor-board-info.txt.

anestisb commented 5 years ago

@thestinger thanks for reporting. Unfortunately I didn't secure any free time yet to properly look the Pixel 3 support (initial support was contributed by other folks). Hopefully, will catch up with the backlog these days.

anestisb commented 5 years ago

The BoardConfigVendor issue has been solved by creating two partials and wrap-around includes based on target.

However, I still can't solve the device-vendor.mk collision (see https://github.com/anestisb/android-prepare-vendor/commit/45c96466ca957e8068a37332f2eecb39368175cd). Let's hope that indeed the required blobs are identical, otherwise I'm not sure it's possible to solve without changes in AOSP.