anestisb / android-prepare-vendor

Set of scripts to automate AOSP compatible vendor blobs generation from factory images
347 stars 155 forks source link

add initial Pixel API 26 configs #82

Closed thestinger closed 7 years ago

thestinger commented 7 years ago

I had to use this temporary hack for now, along with adjusting the download process for the preview images to test this:

diff --git a/execute-all.sh b/execute-all.sh
index ce1ec61..ee13ca7 100755
--- a/execute-all.sh
+++ b/execute-all.sh
@@ -103,9 +103,9 @@ oatdump_prepare_env() {

   if [[ "$HOST_OS" == "Darwin" ]]; then
-    download_url="D_OATDUMP_URL_API$api_level"
+    download_url="D_OATDUMP_URL_API25"
   else
-    download_url="L_OATDUMP_URL_API$api_level"
+    download_url="L_OATDUMP_URL_API25"
   fi

   wget -O "$out_file" "${!download_url}" || {
anestisb commented 7 years ago

Thanks @thestinger. Since I'm currently away from my build/test infra I have limited testing capabilities. However, I'll try to process within the week the stuff you've submitted and finalise them within the scripts.

thestinger commented 7 years ago

@anestisb I don't mind carrying stuff out-of-tree when you aren't doing active development that could conflict with it so don't worry too much. I just wanted to get a head start on this before the Android 8.0 release which will probably around August 21st. I was worried it might be really hard to deal with the Treble related changes, etc. but it doesn't look that bad so far.

thestinger commented 7 years ago

I'll be updating this to the stable release today.

thestinger commented 7 years ago

The changes in the stable release are very minor. There aren't changes to anything other than the contents of the apks for vendor.img and the list of other stuff that I'm including so far. I'll be comparing to a stock image later to see what's missing.

thestinger commented 7 years ago

This now works for the stable release other than needing the API level 26 oatdump workaround for now.