search

anestisb / android-prepare-vendor

Set of scripts to automate AOSP compatible vendor blobs generation from factory images
347 stars 155 forks source link

leave out CarrierSetup for Pixel naked config #88

Closed thestinger closed 6 years ago

thestinger commented 6 years ago

CarrierSetup doesn't appear to have any use in the naked configuration build. It depends on Verizon code that's not included and is triggered by configuration in the GoogleCarrierConfig vendor.xml not present in AOSP. CopperheadOS includes the stock vendor.xml as an overlay, but leaves out the Verizon configuration since it depends on the app suite and isn't required for basic LTE+ functionality without VoLTE / VoWiFi.

The permissions whitelist for CarrierSetup is also in the file for Google Play Services (privapp-permissions-google.xml) rather than the one for the Pixels (privapp-permissions-marlin.xml). If it's included, that whitelist needs to be included too.

thestinger commented 6 years ago

The permissions whitelists might actually be a good guideline for what should go in full vs. naked. This is marlin:

<permissions>
    <privapp-permissions package="com.htc.omadm.trigger">
        <permission name="android.permission.MODIFY_PHONE_STATE"/>
    </privapp-permissions>

    <privapp-permissions package="com.qualcomm.qcrilmsgtunnel">
        <permission name="android.permission.INTERACT_ACROSS_USERS"/>
    </privapp-permissions>

    <privapp-permissions package="com.quicinc.cne.CNEService">
        <permission name="android.permission.PACKET_KEEPALIVE_OFFLOAD"/>
    </privapp-permissions>

</permissions>

I don't think there's a reason to include com.htc.omadm.trigger for the naked configuration though because it doesn't do anything without the full config priv apps.