search

anestisb / android-prepare-vendor

Set of scripts to automate AOSP compatible vendor blobs generation from factory images
348 stars 155 forks source link

libminui.so might be able to come from AOSP #96

Closed thestinger closed 7 years ago

thestinger commented 7 years ago

It looks like it's the library in bootable/recovery/minui, but nothing in AOSP is pulling it in as a dependency. I'm not sure what actually depends on it in the Nexus/Pixel vendor files that makes it get pulled in as a shared library dependency for them, but it's likely possible to set up a dummy module that depends on it and gets it pulled in.

thestinger commented 7 years ago

Not 100% sure that they aren't modifying it but it's usually easy to tell since AOSP builds are deterministic, although I only have around the CopperheadOS oreo-r6-release tree at the moment which does change the build output.

anestisb commented 7 years ago

Ok will check it.

anestisb commented 7 years ago

Except compiler metadata AOSP libminui is identical to factory image. Removed them from blobs list and forced usage of AOSP module in https://github.com/anestisb/android-prepare-vendor/commit/bade1234af29c52033cbdae5856f41702d0e13e0

thestinger commented 7 years ago

Confirmed that this works properly.