search

anexia-it / django-rest-passwordreset

An extension of django rest framework, providing a configurable password reset strategy
BSD 3-Clause "New" or "Revised" License
419 stars 148 forks source link

Added reset by phone number functionality #74

Closed peterolayinka closed 4 years ago

peterolayinka commented 4 years ago

Problem

This package is limited to recovering passwords by email only leaving out use case for where we have users signup with phone number.

solution

Added functionality to recover passwords by phone number.

Vayel commented 4 years ago

Thanks for the PR! It would be convenient to pass the authentication method (email or phone) to the signal's receiver.

enricostano commented 4 years ago

What would be really nice is the ability to define a custom serializer extending the library. For instance in our case we need to identify the user by VAT number.

enricostano commented 4 years ago

Exactly this approach is what I was hoping for https://github.com/anexia-it/django-rest-passwordreset/pull/93

@peterolayinka this would allow you to use phone number @Vayel what do you think?

Vayel commented 4 years ago

@enricostano sounds good to me!

peterolayinka commented 3 years ago

Hi Guys,

Thanks for the review, I totally missed this conversation. I guess this is due to plenty of work-related emails from GitHub.

enricostano commented 3 years ago

@morantron do we still need this?

Morantron commented 3 years ago

@Morantron do we still need this?

yep

enricostano commented 3 years ago

@anx-hnezbeda do you mind keeping this issue open? Thanks!

peterolayinka commented 3 years ago

A universal lookup field as proposed in #93 would also cover phonenumbers, so I would recommend to merge #93 and reject this PR.

@Morantron @enricostano what approach would you prefer to have this merged?

Though, I made a fork already which I use in my codebase.