search

anfabio / upstart

Bookmark Organizer
8 stars 4 forks source link

Do not show icon after add bookmark #2

Open EvgeniyMakhmudov opened 4 years ago

EvgeniyMakhmudov commented 4 years ago

Hello. I try to test this app for FireFox and found this problem. After add bookmark on various sites icon not show изображение

Steps to reproduce:

  1. Open some site, for example https://www.raspberrypi.org/
  2. Click to Add bookmark in right up corner menu of FireFox ( on icon of upStart)
  3. Open start page and see that bookmark was added, but icon do not show. If try to edit bookmark, than see that icon field have value of data:image/webp;base64
EvgeniyMakhmudov commented 4 years ago

i think i found problem. lets see a sorce code of value src="icons/data:image/svg+xml;base64,PHN2ZyB3aWR0aD0iMzIiIGhlaWdodD0iM... the problem is the prefix "icon/" . After delete this prefix the icon show well.

EvgeniyMakhmudov commented 4 years ago

I create PR to fix this problem. I tested it directly of source code of extension in FireFox. I think it a simple code fix, and will be worked well anytime. Any comments are welcome.

EvgeniyMakhmudov commented 4 years ago

@anfabio hello again! I want to remind you to publish new version of extension with the fix of this bug.

anfabio commented 4 years ago

@EvgeniyMakhmudov hello! I am sorry for the delay. I was so busy these past few months I did not had the time to work on this. I took the weekend to review the code and add some minor bug fixes. I alsso added some fucntions using your idea that could be useful. I plan to release a new version this week. Thanks again for your help.