Add to Scoop - Githubissues

anfragment / zen

Simple, free and efficient ad-blocker and privacy guard for Windows, macOS and Linux

https://zenprivacy.net

MIT License

2.26k stars 53 forks source link

Add to Scoop #22

Open sbstn87 opened 10 months ago

sbstn87 commented 10 months ago

Hi,

will it be possible to add Zen to Scoop?

https://scoop.sh/

anfragment commented 10 months ago

I'll look into it.

kzshantonu commented 10 months ago

@anfragment I'll write the manifest and submit a pull request if you want

anfragment commented 10 months ago

@anfragment I'll write the manifest and submit a pull request if you want

Feel free to proceed.

kzshantonu commented 10 months ago

Done! Use the same file names from now on please.

https://github.com/ScoopInstaller/Extras/pull/12428

anfragment commented 10 months ago

Done! Use the same file names from now on please.

ScoopInstaller/Extras#12428

Awesome! Couple small issues:

Zen creates and stores data under user\AppData\Local\Zen. Could you add an uninstall script to clean up the folder?
Zen auto-updates itself on every launch, which is probably not how an app installed via a package manager should behave. I'm already working on providing separate builds with self-updates turned off, could you replace the URLs once they're done?

kzshantonu commented 10 months ago

uninstall script to clean up the folder

This is not recommended because usually scoop users prefer to use the --purge flag if they do want to remove configs. Post-uninstallation scripts run regardless of that flag so wouldn't work. To behave correctly with that flag, config needs to be on the same directory as the executable.

could you replace the URLs once they're done

Sure

anfragment commented 10 months ago

@kzshantonu

could you replace the URLs once they're done

Sure

The latest release and each subsequent one will now include assets named "Zen_windows_amd64_noselfupdate.zip" and "Zen_windows_arm64_noselfupdate.zip" containing binaries with their self-updates disabled.

This is not recommended because usually scoop users prefer to use the --purge flag if they do want to remove configs. Post-uninstallation scripts run regardless of that flag so wouldn't work. To behave correctly with that flag, config needs to be on the same directory as the executable.

I'm not sure if I can prioritize the implementation of a setting for a custom configuration folder path at the moment.

kzshantonu commented 10 months ago

will now include assets named "Zen_windows_amd64_noselfupdate.zip" and "Zen_windows_arm64_noselfupdate.zip"

Updated

I'm not sure if I can prioritize the implementation of a setting for a custom configuration folder path at the moment

That's okay

anfragment commented 10 months ago

Updated

Thanks. I'll close the issue when the pull request gets merged.