search

angband-import / angband-trac

Test importing Trac events into Angband
0 stars 0 forks source link

Make all terminal access/printing functions use (y, x) co-ordinates #54

Open angband-import opened 4 years ago

angband-import commented 4 years ago

Reported by takkaria on 21 Mar 2007 15:16 UTC None

angband-import commented 4 years ago

Comment by pmac on 22 Mar 2007 01:12 UTC This is an extremely high-risk change. I suspect that (row, col) instead of (x, y) would be of somewhat lower risk.

I just checked into this; it seems a likely a way to[[br]] (1) introduce bugs and [[BR]] (2) piss off variant maintainers.

(x,y) is by far the less common ordering both in declarations and uses. It is limited to the various Term_*() functions; everything else is in (row, col) "term-style" orientation.

$ grep " x[0-9]*,.* y" *h | wc
      20     207    1327
Includes 6 false positives; this is used only in z-term.h

$ grep " y[0-9]*,.* x" *h |  grep -v z-term.h | wc
      43     359    2673

$ grep row.*col *h |wc
      12     108     744

Making the change would make it extremely difficult for other variants to reintegrate with V.

angband-import commented 4 years ago

Modified by takkaria on 27 Mar 2007 14:00 UTC

angband-import commented 4 years ago

Modified by magnate on 26 Jul 2009 18:25 UTC

angband-import commented 4 years ago

Modified by magnate on 24 Dec 2010 12:38 UTC

angband-import commented 4 years ago

Comment by takkaria on 22 May 2011 03:57 UTC Changing per suggestion from pmac.