Make squelch simpler and cleaner

[angband-import]

Reported by takkaria on 21 Mar 2007 17:48 UTC Depends on #5, the new menu code.

This requires:

1. shifting all the menus in the squelch file to the new menu system
2. using the new knowledge screens (#7) for some displays
3. documenting the code thoroughly

[angband-import]

Comment by takkaria on 30 Mar 2007 00:22 UTC I think I'm going to significantly alter the patch after playtesting. It's too complex, and the UI is horrible.

• add an option "autopickup things that match inventory"
• add the ability to mark any given object as "destroy on sight"/"always pickup" (=k, =g autoinscriptions, probably)
• remove the current interface for individual items, use the knowledge one instead
• quality-based "destroy weapons/missiles/armour" on pseudo-id (works in pack, as current implementation, almost)

[angband-import]

Comment by pmac on 5 Apr 2007 15:50 UTC I made a first hack at the Quality Squelch menu using the new menu API. It is infinitely simpler code; I don't know if the interface is better, although it is now usable with just a mouse.

[angband-import]

Comment by takkaria on 9 Apr 2007 23:03 UTC Quote:

Since quality squelch doesn't get saved between characters anyway, I'm going to make things easier by removing the attempt to work for both weak- and strong- pseudo-id characters, and just have it use whichever one the current character has.

[angband-import]

Modified by takkaria on 22 Apr 2007 22:17 UTC

[angband-import]

Modified by takkaria on 22 Apr 2007 22:17 UTC

[angband-import]

Comment by pmac on 23 Apr 2007 02:23 UTC Replying to [comment:4 takkaria]: Disagree. Strong-pseudo has real meaning for weak-pseudo characters. Better to just get rid of weak pseudo of "good" items, which is basically the same as squelch-all-but-artifacts. More useful is squelch cursed-but-not-worthless, which allows you to keep Bows of the Nazgul (for SI) but squelches all ordinary cursed bows.

[angband-import]

Modified by pmac on 23 Apr 2007 02:26 UTC

[angband-import]

Modified by takkaria on 2 Jun 2007 12:52 UTC

[angband-import]

Modified by takkaria on 2 Jun 2007 13:04 UTC

[angband-import]

Modified by takkaria on 2 Jun 2007 13:11 UTC

[angband-import]

Modified by takkaria on 3 Jun 2007 15:53 UTC

[angband-import]

Comment by takkaria on 5 Jun 2007 23:30 UTC Done today (will upload patch tomorrow):

Stop squelching items in the pack without choice. Mark items as {squelch} instead of actually being squelched, Ey-style. Auto-mark items as squelch when we find out they're bad (e.g. potions). 'k!' should bring up a menu of just the items to be squelched, to confirm, before hitting "y". Inscribing an item "!k" will rescue it from being squelched.

"Merge inscriptions" option should be always-on. "Verify destruction" option should be always-on.

Remove chest squelching. Remove ego-item squelching.
Remove individual item squelch groups for pseudo-id-able items. They are handled using the quality squelch.

Remove item-based autopickup/neverpickup options, instead add:

Always pickup items matching those in inventory : on (pickup_inven)

[angband-import]

Comment by takkaria on 6 Jun 2007 12:25 UTC Done today (quality squelch screen not quite working fully yet, though):

Move all menus across to the new menu API -- possibly adding "multicolumn" menu display.

Simplify the quality squelch screen to give fewer options. A simple choice of weapons/missiles/armour/lights/etc rather than the massive number of subchoices will still be fine. Remove the crazy "all items" and "just this item" code, make the changes work on a per-group basis.

[angband-import]

Comment by takkaria on 6 Jun 2007 13:16 UTC in [05e0dac] (SVN r156). +667 lines, -1379 lines, -712 net.