search

angband-import / angband-trac

Test importing Trac events into Angband
0 stars 0 forks source link

Simplify the code for timed player effects #72

Closed angband-import closed 4 years ago

angband-import commented 4 years ago

Reported by takkaria on 23 Mar 2007 20:28 UTC xtra2.c contains too much repeated code, so unify it as much as possible.

To fix:

  1. Turn timed player effects into an array
  2. Unify access functions, using a table of {effect} -> {message, flags}
  3. Simplify some more by adding inc, dec, and clear_ functions for the most common use cases.

Already done for the most part. Messy; should this be in 3.0.8?

angband-import commented 4 years ago

Attachment from takkaria on 23 Mar 2007 20:29 UTC sed script to perform replacements, run using `sed -i script.sed *.c" REPLACE THIS TEXT WITH UPLOADED FILE ./attachments/TRAC_60_GIT_72/script.sed

angband-import commented 4 years ago

Comment by takkaria on 29 Mar 2007 17:22 UTC Fixed in [b95c26a] (SVN r24).