search

angel333 / certbot-he-hook

Certbot (Let's Encrypt) auth hook script for the Hurricane Electric DNS service
MIT License
51 stars 19 forks source link

HE.net authentication & domain not found error message #7

Open danielmotaleite opened 4 years ago

danielmotaleite commented 4 years ago

Script is failing with No zone for domain "" found.

Checking the script we get that the cookie format changes, we do not have anymore the CGISESSID cookie, but instead a random id:

 curl -L --silent --show-error -I https://dns.he.net/ |  grep '^Set-Cookie:' 
Set-Cookie: 2915s1a0a47538f8ae75fdef12aca44c56e2b307832d37d25210ba8ed950c3e4=15425ee4e6df96e0c0d23acc4213eb37; path=/; expires=Tue, 09-Jun-2020 10:32:26 GMT
danielmotaleite commented 4 years ago

This PR seems to fix this: https://github.com/angel333/certbot-he-hook/pull/6

zaszlo commented 4 years ago

Can confirm, that without that PR modification the script was failing, using its corrections is working.

Also on line 99 the return should be changed to exit, as that is an exit code and return can be used only from a function. I was also getting this error: /root/certbot-he-hook.sh: line 99: return: can only `return' from a function or sourced script

BR!

NetForces commented 3 years ago

I can also confirm that I was able to get wildcard certs with this patch.