search

angelabad / terraform-aws-msk-cluster

Terraform module which creates Msk Kafka Cluster on AWS
https://registry.terraform.io/modules/angelabad/msk-cluster/
Apache License 2.0
30 stars 34 forks source link

Add option to enable client authentication #8

Closed ldejager closed 2 years ago

ldejager commented 3 years ago

Add option to make use of TLS client authentication using ACM certificates (certificate_authority_arns).

ldejager commented 3 years ago

@angelabad let me know if there is anything else required on the PR.

ldejager commented 3 years ago

@angelabad if you're set on having the code look at whether variables are set in this fashion let me know and I'll amend the PR.

for_each = var.s3_logs_bucket != "" ? ["true"] : []
angelabad commented 3 years ago

for_each = var.s3_logs_bucket != "" ? ["true"] : []

Hi, @ldejager, it sound good to me, you can use this approach to certificate arns.

Thanks!

ldejager commented 3 years ago

@angelabad the changes have been made as requested.

ldejager commented 2 years ago

@angelabad can you please review and provide feedback.

angelabad commented 2 years ago

Hi @ldejager, sorry for my delay, for this feature, nowadays aws provider is buggy, so Im wating for this:

Thanks in advance!

angelabad commented 2 years ago

This is closed in this pr: https://github.com/angelabad/terraform-aws-msk-cluster/pull/21

Thanks