search

angelbruni / Geckium

Chrome 1 - 58 theme for Firefox 115+
Other
93 stars 10 forks source link

Menu hardcoded styling is leaking into platforms where menus use native styling #104

Open dominichayesferen opened 2 days ago

dominichayesferen commented 2 days ago

That Linux Dude Dominic Hayes thatlinuxdude — 11/05/2024 18:20

(excludes MD1+ on Linux as they explicitly hardcode the menus only when Chrome's themed since MD1)

image image

dominichayesferen commented 2 days ago

That Linux Dude Dominic Hayes thatlinuxdude — 11/05/2024 18:22

although, regarding the exception, the bookmarks popouts do need shape/margin-changing to look more native regardless. (edited)

dominichayesferen commented 2 days ago

AwesomeBruni🐧 angelbruni — 11/05/2024 18:23

It's actually the other way around I was gonna make menus use the non-native style so it worked in every platform and nabrious told me to use native menus and style them instead, the issue with that is... Linux native menus don't work properly nowadays so I don't enable it in Linux, meaning that style that was made for native menus is trying to style non-native menus (edited)

dominichayesferen commented 2 days ago

florin florinsdistortedvision — 11/05/2024 18:23

also for 128ESR if thats ever planned bye bye all native menu popups

dominichayesferen commented 2 days ago

AwesomeBruni🐧 angelbruni — 11/05/2024 18:23

It's actually the other way around I was gonna make menus use the non-native style so it worked in every platform and nabrious told

That Linux Dude Dominic Hayes thatlinuxdude — 11/05/2024 18:23

i mean, for Windows it NEVER used native styling ever since at least 47. so in an indirect way nab kinda had a point on the Windows side, surprisingly.

dominichayesferen commented 2 days ago

AwesomeBruni🐧 angelbruni — 11/05/2024 18:23 It's actually the other way around I was gonna make menus use the non-native style so it worked in every platform and nabrious told

That Linux Dude Dominic Hayes thatlinuxdude — 11/05/2024 18:23

i mean, for Windows it NEVER used native styling ever since at least 47. so in an indirect way nab kinda had a point on the Windows side, surprisingly.

AwesomeBruni🐧 angelbruni — 11/05/2024 18:24

Yes, but the native menus are the closest to the 47+ ones, so he told me to just style those instead, even though I wanted to style the non-native ones. would be better so it worked on every platform

dominichayesferen commented 2 days ago

That Linux Dude Dominic Hayes thatlinuxdude — 11/05/2024 18:24

though, yeah, I suppose this is already a mute topic anyway with the native menus being gone in Firefox 128. (edited)

dominichayesferen commented 2 days ago

AwesomeBruni🐧 angelbruni — 11/05/2024 18:25

Yeah That's another thing

dominichayesferen commented 2 days ago

florin florinsdistortedvision — 11/05/2024 18:25

yeah imo its better to style the non native menus

dominichayesferen commented 2 days ago

AwesomeBruni🐧 angelbruni — 11/05/2024 18:25

He knew we wanted to support 128 (edited)

dominichayesferen commented 2 days ago

florin florinsdistortedvision — 11/05/2024 18:25

would be a less need to even use xul even on 115esr

dominichayesferen commented 2 days ago

That Linux Dude Dominic Hayes thatlinuxdude — 11/05/2024 18:25

also

dominichayesferen commented 2 days ago

AwesomeBruni🐧 angelbruni — 11/05/2024 18:25

Honestly I shouldn't let this get to me but I do get very frustrated everytime something could've been prevented if I could've done things my way (edited)

dominichayesferen commented 2 days ago

florin florinsdistortedvision — 11/05/2024 18:25

ive seen geckium is heavyly based around the xul patch

dominichayesferen commented 2 days ago

That Linux Dude Dominic Hayes thatlinuxdude — 11/05/2024 18:25

wouldn't non-native menu styling just be easier generally

dominichayesferen commented 2 days ago

florin florinsdistortedvision — 11/05/2024 18:25

they are

dominichayesferen commented 2 days ago

That Linux Dude Dominic Hayes thatlinuxdude — 11/05/2024 18:25

since you'd probs need to appearance: none the native ones for the other possibility.

dominichayesferen commented 2 days ago

AwesomeBruni🐧 angelbruni — 11/05/2024 18:25

Honestly I shouldn't let this get to me but I do get very frustrated everytime something could've been prevented if I could've done things my way (edited)

That Linux Dude Dominic Hayes thatlinuxdude — 11/05/2024 18:26

throw it out while nuking nab-code. image

dominichayesferen commented 2 days ago

AwesomeBruni🐧 angelbruni — 11/05/2024 18:26

👍

dominichayesferen commented 2 days ago

That Linux Dude Dominic Hayes thatlinuxdude — 11/05/2024 18:27

also also keep in mind that Linux is permanently non-native in regards to Firefox menus you can technically use the native stuff as textures on the non-native menus in Linux-Firefox at least.

Is it native? - Linux

EVERYTHING before MD1

Themed: Yes - GTK Not themed: Yes - GTK

MD1 to present

Themed: No - Windows styling Not themed: Yes - GTK at least iirc MD1 debuted the in-theme hardcoding, rather than MD2.

Is it native? - macOS

Yes.

...actually idk, seems like the MD2+ eras use Windows styling...? I forget when that debuted in macOS, unfortunately, though. (edited)

dominichayesferen commented 2 days ago

That Linux Dude Dominic Hayes thatlinuxdude — 11/05/2024 21:00

edit: MD1 still used native menus. https://youtu.be/19UZcGczmbA ...and indeed debuted in MD2 instead. https://youtu.be/vSLd_IE3GCk (edited)