angelbruni / Geckium

Chrome 1 - 58 theme for Firefox 115+
Other
34 stars 6 forks source link

lwtheme titlebar texture offset is no more #189

Closed dominichayesferen closed 1 day ago

dominichayesferen commented 1 day ago

That Linux Dude Dominic Hayes thatlinuxdude — 08/09/2024 22:00

It helped this theme to be visible for instance

image

dominichayesferen commented 1 day ago

AwesomeBruni🐧 angelbruni — 08/09/2024 22:02

It was made specifically for this theme wasn't it? I remember using this theme's ID specifically Lol

dominichayesferen commented 1 day ago

That Linux Dude Dominic Hayes thatlinuxdude — 08/09/2024 22:03

also how Firefox handles it

image

dominichayesferen commented 1 day ago

AwesomeBruni🐧 angelbruni — 08/09/2024 22:03

Interesting I'll look into it

dominichayesferen commented 1 day ago

KAWKNAKNWKA kwanvini — 09/09/2024 16:21

image

dominichayesferen commented 1 day ago

AwesomeBruni🐧 angelbruni — 09/09/2024 16:22

whar

dominichayesferen commented 1 day ago

KAWKNAKNWKA kwanvini — 09/09/2024 16:23

nothing................

dominichayesferen commented 1 day ago

AwesomeBruni🐧 angelbruni — 09/09/2024 23:35

This is because the background relies on center alignment In Firefox, the size of the background is the element that includes both titlebar and tabs And what we are doing instead is setting the height value to the height of the image which is bigger than 81px 81px forced

image

i guess this makes the argument of "nobody cares about tiling because borders don't exist" invalid (edited) In reality, the background doesn't extend to the entire browser's height at all (makes sense) I guess I'll just force... 81? idk yet

dominichayesferen commented 1 day ago

AwesomeBruni🐧 angelbruni — 09/09/2024 23:35

This is because the background relies on center alignment In Firefox, the size of the background is the element that includes both titlebar and tabs And what we are doing instead is setting the height value to the height of the image which is bigger than 81px 81px forced

image

i guess this makes the argument of "nobody cares about tiling because borders don't exist" invalid (edited) In reality, the background doesn't extend to the entire browser's height at all (makes sense) I guess I'll just force... 81? idk yet

That Linux Dude Dominic Hayes thatlinuxdude — 09/09/2024 23:45

if it's centered, then... actually wait nvm my math would need more mathing first

dominichayesferen commented 1 day ago

AwesomeBruni🐧 angelbruni — 09/09/2024 23:46

😳