angelf / escargot

ElasticSearch connector for Rails - Abandoned!
MIT License
61 stars 20 forks source link

Make gem bundler compatible and remove dependency on activerecord #11

Open rubish opened 13 years ago

rubish commented 13 years ago

Thanks for the wonderful gem. I am using it with the mongoid on rails 3.0.4, by including include Escargot::ActiveRecordExtensions in my model and defining table_exists? and find_in_batches method for my models. I also had to include the rake tasks manually and copy the init file to initializers. Till now its working perfectly fine.

There are only few changes required to make the gem compatible with Rails 3.0.4 and MongoID:

I would love to contribute to the gem, but am currently busy with a project. Let me know if you would like me to work on it.

jeroig commented 13 years ago

Thanks you to use it.

Of course you can assist in the development of the gem. We would be grateful.

Only you have to do is : Fork, code, send pull request of your changes.

I remember, in order to maintain the robustness of the gem, any pull request need to pass the test suite. We accepts changes more quickly if it's coming with his own test passed.

Anything you need, let us know.

ps: Sometimes we don't realize the benefits of the change, so (and not always) we ask to you explications Why this change of the new code?, Which are the adventages?

rubish commented 13 years ago

Thanks for the reply.

Benifits are simple:

I would first attempt to get it working with rails3, by making following modifications:

Let me know if it sounds good or I can approach it in a different manner.

PS: I have never worked with gems and plugins and would very much appreciate if you can guide me from where should I start? How to setup my own gem for testing? or point me towards right resources.

jeroig commented 13 years ago

Hi rubish,

I'm agree with the changes. could give me your email? And i explain to you how to configured the project for testing.

Thanks

pfeiffer commented 13 years ago

Would love to see this happen :-)

mid9commander commented 13 years ago

I have it working for rails 3 and MongoMapper, I am a bit swamped at the moment to create test for it, if anyone has some time on their hand, they are more than welcome to take what I have in my fork and create test for it.

jeroig commented 13 years ago

hi @mid9commander

could give me your email? And i explain to you how to configured the project for testing.

Thanks

mid9commander commented 13 years ago

check my github profile, I just updated it to have my email address visible. Thank you.

pfeiffer commented 13 years ago

@jeroig Would it be possible for you to add the testing instructions as a wiki-page in the repository?

jeroig commented 13 years ago

hi @pfeiffer,

No problem, i have never use the wiki - page but i will try now

jeroig commented 13 years ago

https://github.com/jeroig/escargot/wiki/How-i-set-up-Escargot-for-testing