search

angeliquekom / vue-json-to-csv

A Vue.js 2 component for transform and download a json in csv format
MIT License
35 stars 9 forks source link

handleError shouldn't throw if error event attached #12

Open esemlabel opened 4 years ago

esemlabel commented 4 years ago

handleError method always throw error regardless of hasErrorEvent value, thus $emit('error') won't work and execution of application completely stops. we should either emit error if hasErrorEvent, or throw otherwise, but not do them both.

esemlabel commented 4 years ago

Additionally, there would be good to have option to skip error for empty data set, since it's not an error in most cases.