search

angell-co / Pimp-My-Matrix

A plugin for Craft that lets you enhance a busy Matrix field and organise block types
MIT License
60 stars 5 forks source link

Leave this page confirmation without changing content #35

Open dreadfullyposh opened 8 years ago

dreadfullyposh commented 8 years ago

I've noticed that Craft's "any changes will be lost if you leave this page" dialog comes up on entries that have blocks with Pimp My Matrix tabs enabled even if nothing has been changed.

From my testing, it appears that this happens only after you change tabs on one of the blocks.

Is there any way to reset the flag that triggers that dialog after changing tabs?

joshangell commented 8 years ago

I'm not totally sure there is a way of re-setting that reliably, more desirable would be to suppress the clicks from the tabs from bubbling up to whatever is listening that triggers that alert.

I'll certainly take a look when I next get round to working on this :smile:

marcato15 commented 7 years ago

Checking in on this feature request. Looks like you removed the assignment. Is that because you're unable to work on it any more? Just checking b/c this would prevent us from using the plugin. If you can't maintain it then we'll look at either forking and submitting a PR or just not using it.

joshangell commented 7 years ago

@marcato15 Yes I’m afraid I am unable to work on this project any more due to other work commitments. If its a simple PR with no obvious conflicts then @Nav33d may consider merging it 🙂

marcato15 commented 7 years ago

Sounds good.

Nav33d commented 7 years ago

@marcato15 PRs are always welcome :)

One thing to keep in mind that we are no longer supporting this plugin and won't be porting it over to Craft 3