search

angelnikolov / ts-cacheable

Observable/Promise Cache Decorator
https://npmjs.com/package/ts-cacheable
ISC License
340 stars 42 forks source link

Upgrade rxjs version dependency #18

Closed zcmander closed 5 years ago

zcmander commented 5 years ago

I tried to upgrade my application from Angular 6 to 7 and because ngx-cacheable uses rxjs version 6.2, it raises an error:

λ  ng update @angular/cli @angular/core
                  Package "ngx-cacheable" has an incompatible peer dependency to "rxjs" (requires "6.2.0", would install "6.3.3").
Incompatible peer dependencies found. See above.

RXJS change log can be found at: https://github.com/ReactiveX/rxjs/blob/master/CHANGELOG.md#630-2018-08-30

zcmander commented 5 years ago

Using -Force resolve the upgrade issue, altough the original issue stil remains and i can't see the reason not to upgrade.

angelnikolov commented 5 years ago

@zcmander Are you sure that's caused by ngx-cacheable's dependency? It's listed as a peerDependency of ^6.2.0 so if your other packages allow it, it should properly install 6.3.3? Am I missing something?

zcmander commented 5 years ago

Sure it's because of the ngx-cacheable. Npm only issues this one as a warning, so it will install newer version just fine.

Original issue occured when using ng update, so this issue might ne related to that. Anyway, because it is just a warning, to me this issue can be closed, because I can work around it, and I dont really know a lot about of the packaging in node.

angelnikolov commented 5 years ago

Got it!