search

angelnikolov / ts-cacheable

Observable/Promise Cache Decorator
https://npmjs.com/package/ts-cacheable
ISC License
340 stars 42 forks source link

shouldCacheDecider in GlobalConfig #68

Closed krogh closed 4 years ago

krogh commented 4 years ago

First of all, thank you for this very nice library! I would like to apply a global shouldCacheDecider policy. shouldCacheDecider exists in the interface ICacheConfig but not in the GlobalCacheConfig. Is this deliberate or a missing setting? The Readme indicates it should be in the GlobalCacheConfig as well. I can see there has been a discussion of global versus local config https://github.com/angelnikolov/ngx-cacheable/issues/57 If shouldCacheDecider should be included I could make a pull request based on #57 to ease your work. I just wanted to hear your intentions first Best wishes and thank you Michael

angelnikolov commented 4 years ago

@krogh Yeah, I must have forgotten adding that option to the global config. If you wish, you can make a PR and I will publish :) Otherwise, I can do it in the next couple of days. Thanks!

krogh commented 4 years ago

I will leave you to it then :-) Thank you!

krogh commented 4 years ago

I actually had some time to try it out See the pull request

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.