search

angelnikolov / ts-cacheable

Observable/Promise Cache Decorator
https://npmjs.com/package/ts-cacheable
ISC License
340 stars 42 forks source link

fix: create unique ID per target #89

Closed jigfox closed 3 years ago

jigfox commented 4 years ago

this prevents the cacheKey from beeing shared for multiple requests in angular universal

see #85

codecov[bot] commented 4 years ago

Codecov Report

Merging #89 into master will decrease coverage by 0.80%. The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #89      +/-   ##
==========================================
- Coverage   94.22%   93.42%   -0.81%     
==========================================
  Files          11       11              
  Lines         225      228       +3     
  Branches       58       60       +2     
==========================================
+ Hits          212      213       +1     
  Misses          4        4              
- Partials        9       11       +2
Impacted Files Coverage Δ
cacheable.decorator.ts 95.08% <90.90%> (-3.20%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 94c7635...27c3433. Read the comment docs.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.