angelnu / pod-gateway

Container image used to set a pod gateway
Apache License 2.0
56 stars 29 forks source link

Make dnssec support optional #23

Closed mergwyn closed 1 year ago

mergwyn commented 1 year ago

Description of the change Having dnssec enabled doesn't work in my environment as my upstream local dns servers (samba) don't support dnssec. This is achieved by and extra environment variable GATEWAY_ENABLE_DNSSEC which defaults to true to keep the existing behaviour.

Benefits This change will allow the PR22 "Add DNSSEC Support " from the k8athome repo to be optionally reverted. A

Possible drawbacks

Applicable issues

Additional information

mergwyn commented 1 year ago

I didn't want to merge this change request at this time - I have just made the change and am now working out how to test it!

angelnu commented 1 year ago

If DNSSEC is creating issues we can disable by default