search

angeloashmore / gatsby-source-shopify

Source plugin for pulling product data into Gatsby from a Shopify store
36 stars 19 forks source link

Update touchnode to use object due to deprecation in Gatsby v2 #14

Open gil-- opened 6 years ago

gil-- commented 6 years ago

See https://next.gatsbyjs.org/docs/actions/#touchNode

Note: The plugin still works, it just spits out a bunch of deprecation warnings.

Calling "touchNode" with a nodeId is deprecated. Please pass an object containing a nodeId instead: touchNode({ nodeId: 'a-node-id' })
"touchNode" was called by gatsby-source-shopify
Calling "touchNode" with a nodeId is deprecated. Please pass an object containing a nodeId instead: touchNode({ nodeId: 'a-node-id' })

I'm guessing this would break v1 compatibility? Not sure if there's a more graceful way to support v1 or if plugins will simply stop supporting Gatsby v1

camsloanftc commented 6 years ago

@angeloashmore - would it be possible to get eyes on this?

angeloashmore commented 6 years ago

@camsloanftc Leaving for work now, but I'll take a look at this tonight and tomorrow morning 👍