search

angelobreuer / Lavalink4NET

Lavalink4NET is a Lavalink wrapper with node clustering, caching and custom players for .NET with support for Discord.Net, DSharpPlus, Remora, and NetCord.
https://lavalink4net.angelobreuer.de/
MIT License
154 stars 27 forks source link

refactor!: Improve strict search #139

Closed angelobreuer closed 9 months ago

angelobreuer commented 9 months ago

This PR will solve various problems that were present with the old strict search solution. The default will stay to be the most pedantic option (Throw) which will fail if Lavalink4NET recognizes an attempt of the user trying to specify a search mode. However, this option also flagged search queries like PR: abc which may be valid search queries for some tracks. The option Resolve solves this problem by prepending the search prefix to those queries.

Please read the documentation of StrictSearchBehavior to learn more about the various new behaviors.

For users that previously enabled or disabled strict search, the option Throw matches the exact behavior as previously when strict search was enabled. The Passthrough options most likely matches the behavior as when strict search was disabled.

github-actions[bot] commented 9 months ago

Delta Summary
Generated on: 01/27/2024 - 13:29
Description Previous Current Delta
Coverage date: 01/23/2024 - 09:03 01/27/2024 - 13:29
Line coverage: 66.9% 66.9% 0.0%
Covered lines: 14084 14119 35
Coverable lines: 21044 21081 37
Total lines: 31235 31833 598
Branch coverage: 47.2% 47.4% 0.2%
Covered branches: 2226 2251 25
Total branches: 4714 4740 26
Method coverage: Feature is only available for sponsors