Add Lyrics.Java support - Githubissues

angelobreuer / Lavalink4NET

Lavalink4NET is a Lavalink wrapper with node clustering, caching and custom players for .NET with support for Discord.Net, DSharpPlus, Remora, and NetCord.

https://lavalink4net.angelobreuer.de/

MIT License

150 stars 27 forks source link

Add Lyrics.Java support #148

Closed KMen1 closed 6 months ago

KMen1 commented 6 months ago

I have found great use of the Lyrics.Java plugin and think it would be great to have native support for it in Lavalink4NET!

This integration

Automatically fetches the lyrics for the current track in NotifyLyricsLoadedAsync.
Adds GetCurrentTrackLyricsAsync, GetYoutubeLyricsAsync, GetGeniusLyricsAsync and SearchAsync extension methods to ILavalinkApiClient.
Adds documentation for the integration and updates the readme to include it

If looking forward to getting feedback on this PR and hopefully getting it merged!

angelobreuer commented 6 months ago

Very cool 🎉 thank you a lot!

angelobreuer commented 6 months ago

Linking https://github.com/DuncteBot/java-timed-lyrics/issues/4

angelobreuer commented 6 months ago

Can you take a look at the modifications I made and check if they suit your use-case? Maybe there is something you find odd or could be improved

KMen1 commented 6 months ago

Yes, it's perfect like this 👌