search

angelodlfrtr / open-meteo-rs

Rust API client for https://open-meteo.com/
MIT License
18 stars 4 forks source link

`Location` implementation #8

Open angelodlfrtr opened 7 months ago

angelodlfrtr commented 7 months ago

Support to geo primitives like geo#Point could be added, maybe under a feature.

thulasizwe-ntamane commented 2 months ago

Hi guys,

Firstly, great work on this API - it's simple to use and intuitive.

I noticed that the module crashes when geolocation fails, perhaps from garbage data or the geolocation cannot return coordinates.

I have applied a fix in an offline branch created from the main branch and would like to contribute these changes.

angelodlfrtr commented 2 months ago

Hi @thulasizwe-ntamane, great, do not hesitate to create a pull request !

You can watch for github doc about creating pull request : https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/proposing-changes-to-your-work-with-pull-requests/creating-a-pull-request