search

angelolab / Nimbus

Other
12 stars 1 forks source link

Eval splits #54

Closed JLrumberger closed 1 year ago

JLrumberger commented 1 year ago

What is the purpose of this PR?

Added eval split jsons for hickey and msk_pancreas

Remaining issues

None

JLrumberger commented 1 year ago

Hi @srivarra, the build fails on travis but not locally. I reran Travis CI - Branch on main and it also fails now, even though it passed just a couple of days ago. The error message is ImportError: cannot import name 'Config' from 'pytest' (/home/travis/virtualenv/python3.9.12/lib/python3.9/site-packages/pytest/__init__.py). I googled it and found this messy stackoverflow thread, but both of their proposed solutions (getting rid of init.py at the top level or adding conftest.py) are already in place. Do you have an idea on how to fix it or already experienced this error?

srivarra commented 1 year ago

@JLrumberger We removed Travis from all the other repos, and I'm working on getting GitHub actions on this repo!

JLrumberger commented 1 year ago

Oh! Thanks for letting me know.

ngreenwald commented 1 year ago

As long as everything is passing locally we can merge it in once you're ready

JLrumberger commented 1 year ago

Branch had conflicts with main. I made a new branch and added the changes, so this PR can be closed.