Closed srivarra closed 1 year ago
@srivarra the PR looks good I'd say. What's with the CI/Upload Coverage action?
@JLrumberger I'm not too sure, it says that there is nothing to report which is super odd, as this is the same setup we use for many of our other repos. I'll try uploading the coverage directly after running the tests.
I've tried that, and it is possibly because the workflow isn't in the main branch yet, see here.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Adds GitHub Actions, and adjusts the project to a
src
layout.How did you implement your changes
GitHub Actions + src layout
Adds GitHub Actions. Adjusts the structure of the repo, moves all tests to a
test
directory. Uses thesrc/package
layout.Here is the new structure of the repo.
pyproject.toml
.travis.yml
Testing
Added a fixture for loading in the
params.toml
file inconftest.py
, so we don't need to load it in per test, just pass the fixture's name for any test which needs it.You can install the testing dependencies with
pip install .[test]
.Remaining issues
Currently due to DeepCell's strict TF 2.8 dependency, we cannot test this on non x86_64 machines (i.e. no Apple Silicon). Apple Silicon support requires the usage of specific Conda environments (see here), and is not
pip
installable.Misc Notes