If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #1028. Add current processing FOV name to progress bar output in the ark notebooks.
Closes #970. Fix incorrect progress bars that show <100% even though the batch was processed fine.
How did you implement your changes
Update the FOV name at start of each code block using progress_bar.set_postfix(FOV=fov).
I was able to replicate @HPiyadasa's issue, and it turns out two things could potentially happen with the current code:
Since we only check the progress every 3 seconds, sometimes we don't always know that the last fov is in progress before getting a "done" response from the api and closing the progress bar. We simply need to ensure the progress bar gets updated for completion before breaking the batch loop and closing the progress bar.
(This one is quirky) Sometimes deepcell.org/api/redis will return a lower completion rate than it had before. When combined with the above issue, the math doesn't math to 100. We just need to account for this by only updating the progress bar status when it has increased.
HPiyadasa
commented
1 year ago
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
How did you implement your changes
Update the FOV name at start of each code block using
progress_bar.set_postfix(FOV=fov).I was able to replicate @HPiyadasa's issue, and it turns out two things could potentially happen with the current code:
Remaining issues
Nothing, I've solved all issues forever.