Closed camisowers closed 8 months ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
3x3 looks fine on my end, but will you try 4x4 and see if that's better? Could be a windows thing, but if it helps we can just change it.
I agree we can just get rid of the cluster_type
arg from create_mantis_project()
(I think it was just a copy over from create_mantis_dir()
) and is unnecessary.
The small_table is needed because new clusters can be create in the post clustering notebook, and the original mapping from the cell clustering gui no longer is accurate for these masks when making the mantis directory. We need to create a new mapping and this subsetted cell table is also just easier to pass into ClusterMaskData
than the whole cell table.
@cliu72 5x5 with dpi=150 looks great on my end! Once you approve I can merge it in.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Closes #1075. Make minor tweaks to Pixie notebooks regarding plotting output.
Closes #1082. Ensure that the correct integer IDs are mapped to each cell cluster name in Mantis viewer.
How did you implement your changes
The
erode
parameter inplot_utils.plot_pixel_cell_cluster()
is defaulted to True. Since it is also explicitly set to True in both the pixie cell clustering and generic cell clustering notebooks, we can just set the default to False to remove it from the pixel clustering output.Adjust the
data_utils.generate_and_save_cell_cluster_masks()
function to update the cell_meta_cluster_mapping.csv at the same time it generates new integer IDs for the cell cluster masks. The new 'cluster_id' column is then read intoplot_utils.create_mantis_dir()
instead of the outdated 'cell_meta_cluster' values; this allows an accurate cell cluster mapping file to be generated and uploaded into mantis viewer.Remaining issues
None. This bug had no effect on the cell table, since only the cluster name (not the integer ID) is stored there. Post-clustering is also not an issue, since a custom integer mapping is created in the
create_mantis_project()
function.