search

angelolab / ark-analysis

Integrated pipeline for multiplexed image analysis
https://ark-analysis.readthedocs.io/en/latest/
MIT License
69 stars 25 forks source link

1100 empty composites masks in ez segmenter notebook #1101

Closed bryjcannon closed 4 months ago

bryjcannon commented 6 months ago

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR? Fixes issue in #1100 where float images were not able to be used in composite, mask creation.

How did you implement your changes

Image loading was converted from np.int32 to np.float32, plus additional handling of composite array addition and subtraction functions.

Remaining issues

None as of now, may run into issues if non float or int img datatypes are used.

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

camisowers commented 6 months ago

Looks good! Once we get the build fixed, it's good to go.