Closed srivarra closed 1 year ago
Check out this pull request on
See visual diffs & provide feedback on Jupyter Notebooks.
Powered by ReviewNB
We should get the sequencing right for all of this. If @cliu72 wants the updated version for her paper to to be 3.9+, then we should wait on merging in #985 until after this.
If not, then we should make a new release once her other requests get merged in, then #985, then this.
Yeah I think it'd be good for the updated version of my paper to be 3.9+, since pip install doesn't work anymore with the old version. So I think we can merge this one now.
@ngreenwald @cliu72 This is good to go.
@camisowers @alex-l-kong Added the fix in for watershed
's argument dtype
.
If you haven't already, please read through our contributing guidelines before opening your PR
What is the purpose of this PR?
Adds a Conda environment using Python 3.11. The docker environment now uses a slim Python 3.11 Image.
How did you implement your changes
Environment Changes
Added the
environment.yml
file, adjusted theDockerfile
, made changes to theREADME
and reformatted thesetup.py
file. Support for Python 3.9 to 3.11.Added the following extensions:
These extensions are not dependencies of Ark, they are installed alongside Ark in the Conda
environment.yml
and the Docker image Dockerfile, and can be optionally installed withpip install ark-analysis[lab_ext]
orpip install .[lab_ext]
if you are in the ark directory.Testing Changes
dimensionality_reduction_test.py
from 300 to 50.Removed unused imports in
src/ark/
,tests/
, andtemplates/
Sorted all imports with
isort
, removed unused imports.Remaining issues Merge the following before this pr: