adds xarray return option to _extract_bin_files

angelolab / mibi-bin-tools

Tools for extracting TIFF images from mibiscope bin files

MIT License

0 stars 3 forks source link

adds xarray return option to _extract_bin_files #23

Closed ackagel closed 2 years ago

ackagel commented 2 years ago

closes issue #20

direct ndarray return would've been a little awkward with 5 dimensions (fov, pulse/intensity/area, x, y, channel), so I settled for an xarray return.

ackagel commented 2 years ago

@ngreenwald lmk if you want me to expand on the testing at all. for now, I'm just making sure that the correct dimension names are returned. If we want to check for full correctness (as in file writes match direct returns) then I can move those calls into the tempfile context and check in there. That felt a little overkill, but I can totally implement that if you think it's worth it.