search

angelolab / toffy

Scripts for interacting with and generating data from the commercial MIBIScope
MIT License
10 stars 3 forks source link

`combine_compensation_matrices` should not add the channel row indices together #441

Closed alex-l-kong closed 10 months ago

alex-l-kong commented 11 months ago

Describe the bug

The way the Rosetta matrix is currently stored, the row indices are a separate column and don't get loaded in as an index. This means they should not be considered during the addition process of the compensation matrices.

Expected behavior

  1. We should skip the 0th column index when adding the matrices together
  2. We should strongly consider changing the way the Rosetta matrix is loaded in, we should specify the first column as an index, rather than make it a separate column. This would be better addressed in a separate issue.

To Reproduce

Run the Rosetta round 2 notebook as is.