search

angelolab / toffy

Scripts for interacting with and generating data from the commercial MIBIScope
MIT License
10 stars 3 forks source link

Normalization notebook bug #461

Closed camisowers closed 6 months ago

camisowers commented 6 months ago

If you haven't already, please read through our contributing guidelines before opening your PR

What is the purpose of this PR?

In the normalization notebook, mph_run_dir is passed into plot_detector_voltage() before it is created, which causes an error if a user it running 4b without running the watcher notebook first.

Also fixes a minor readme typo.

How did you implement your changes

Simply move up the os.makedirs() call in the notebook, to avoid any issues.

Remaining issues

NA

review-notebook-app[bot] commented 6 months ago

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB