search

angeloskath / php-nlp-tools

Natural Language Processing Tools in PHP
Do What The F*ck You Want To Public License
745 stars 152 forks source link

fix ErrorException #25

Closed thetiby closed 10 years ago

thetiby commented 10 years ago

"Only variables should be passed by reference" PHP 5.4.3

angeloskath commented 10 years ago

Sorry for the exceptionally belated reply. The error is correctly pointed out and it actually passed the tests because it only produces a notice "PHP Strict Standards: Only variables should be passed by reference".

Still I would prefer not to merge this particular pull request. Could you please make another one against the develop branch? And I think it is a better solution to not require the class_set to be passed by reference since we do not want to change it and it is probably going to be a small array as well.

Really thanks for taking the time to contribute and really sorry for me not being responsive.

thetiby commented 10 years ago

Hi there, Thank you very much for your work. I merely submitted this pull request as a way of letting you know of this - didn't try to go for the optimal solution but for the easiest one (I used your Naive Bayes classifier in a project and was stuck on this error, so used this as a quick fix).

I'll take another look at this in the foreseeable future and maybe submit another PR. Meanwhile, please close this one.

Thank you again.

angeloskath commented 10 years ago

Ok, thanks. I haven't got as much time to devote to the library as I used to but I am in the process of merging the develop branch to the master, taging it as version 0.1 and updating the documentation site. I will have it fixed before I merge into master.