search

angeloskath / php-nlp-tools

Natural Language Processing Tools in PHP
Do What The F*ck You Want To Public License
753 stars 153 forks source link

added Jaro-Winkler Distance #54

Closed jtejido closed 3 years ago

angeloskath commented 6 years ago

Hey, the test is failing :-) . Great work though! Thanks for the PRs.

I would also change JaroWinklerDistance the same way that I changed the TverskyIndex. The dist() and similarity() functions should not change. The constructor should accept parameters that change how the distance behaves.

jtejido commented 6 years ago

Hi,

Thanks for considering the PRs. I've edited the PR to follow the Interface :)