search

angeloskath / supervised-lda

A flexible variational inference LDA library.
MIT License
22 stars 5 forks source link

EM step clarification #9

Closed angeloskath closed 8 years ago

angeloskath commented 8 years ago

In the em namespace a lot of classes are redundant or poorly named. I propose the following changes in order to clarify the steps and make it easier to associate them with the appropriate research papers (⇒ means rename, this means deleted).

  1. ApproximateSupervisedEStep ⇒ FastSupervisedEStep
  2. SecondOrderSupervisedMStep ⇒ SupervisedMStep
  3. SupervisedMStep ⇒ FastSupervisedMStep
  4. OnlineSupervisedMStep ⇒ OnlineFastSupervisedMStep
  5. FastSupervisedEStep
  6. FastUnsupervisedEStep

@paschalidoud what should we do with CorrespondenceSupervised*Step, MultinomialSupervised*Step ?

All steps shall check for convergence using the mean variational parameter change instead of the likelihood.

See #8 for likelihood estimation.