angelozerr / angular-eclipse

Angular Eclipse Plugin
https://angular.io/
Eclipse Public License 1.0
69 stars 12 forks source link

Angular2 Nature #7

Open angelozerr opened 8 years ago

angelozerr commented 8 years ago

How to determine that a project has Angular2 nature?

But those folder, package.json could be hosted not only in project root (like src folder). So we could foolw the same idea than https://github.com/angelozerr/typescript.java/issues/12#issuecomment-192862224

And at the end if the user project doesn't follow thoses rules, user will be able to to "Convert as Angular2" to add Eclipse Angular2 nature to the project.

What do you think about that @micaelgallego @piotrtomiak

micaelgallego commented 8 years ago

+1 To search in package.json. As far as I know, it is the common way to obtain angular2 dependencies.

If you search only in node_modules, what happen if npm install haven't executed yet? What do you plan to do if node_modules folder is missing?

piotrtomiak commented 8 years ago

Agreed with @micaelgallego: package.json seems like a very good place to look for the stuff and have a failsafe with nature if not found (Convert as Angular2 and add nature).