search

angelozerr / angularjs-eclipse

AngularJS Eclipse Plugin
https://angularjs.org/
Eclipse Public License 1.0
328 stars 90 forks source link

Add support for angularjs-eclipse features in advanced custom bootstrap scenarios like portlets #116

Closed gamerson closed 9 years ago

gamerson commented 9 years ago

If you import the test project here: https://github.com/gamerson/angular-portlet/tree/ide You will notice that angularjs features are unable to work correctly. Even with "hinting" by linking jsp files to certain modules it doesn't seem to work as expected.

gamerson commented 9 years ago

workspace 1_026

angelozerr commented 9 years ago

@gamerson after studying your problem I have doen a quick fix.

Your problem was that you don't use string to name your angular module (see https://github.com/gamerson/angular-portlet/blob/ide/src/main/webapp/js/main.js#L3). Instead of doing that : 

var module = angular.module('store');

you do that :

var module = angular.module(id);

where id is a parameter of your bootstrap function.

My fix is that now I support angular.module with variable name. You can retrieve your module with #id in the angular explorer and after you can link it to your HTML.

Tell me if it's OK.

gamerson commented 9 years ago

That sounds good.

angelozerr commented 9 years ago

That sounds good.

cool! Can I close this issue?

gamerson commented 9 years ago

So is that feature available now? the finding by id? I was unable to see it working from master. Was there something extra I needed to do?

On Wed, Oct 22, 2014 at 8:53 PM, Angelo notifications@github.com wrote:

That sounds good.

cool! Can I close this issue?

— Reply to this email directly or view it on GitHub https://github.com/angelozerr/angularjs-eclipse/issues/116#issuecomment-60079574 .

Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com

angelozerr commented 9 years ago

Fix was done https://github.com/angelozerr/tern.java/commit/3048fc792b918083e424875912c80f07f837ee6d inside tern.java

gamerson commented 9 years ago

Verified, thanks you can close this issue now.

On Wed, Oct 22, 2014 at 8:56 PM, Angelo notifications@github.com wrote:

Fix was done angelozerr/tern.java@3048fc7 https://github.com/angelozerr/tern.java/commit/3048fc792b918083e424875912c80f07f837ee6d inside tern.java

— Reply to this email directly or view it on GitHub https://github.com/angelozerr/angularjs-eclipse/issues/116#issuecomment-60079982 .

Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com