search

angelozerr / eclipse-wtp-webresources

Provides completion, hyperlink, hover inside WTP HTML editor for Web Resources (CSS, JS, Images)
Eclipse Public License 1.0
13 stars 9 forks source link

Support scss files #8

Closed gamerson closed 10 years ago

gamerson commented 10 years ago

In our liferay ide extension (to support bootstrap classes) we need to let the ICSSModel open scss files. We have added the necessary contentType extensions in our plugin, but we need the webresources collector to not ignore scss files for CSS resourceType.

angelozerr commented 10 years ago

Thank's @gamerson !

gamerson commented 10 years ago

Thanks for the merge, but I just realized that for liferay aui taglibs the css completion is not getting invoked,

<aui:button cssClass="|" ... />

Do you have any ideas how I could get the completion to fire on arbitrary node attributes?

angelozerr commented 10 years ago

Ok, I had not though about this case -(

Today it's hard coded https://github.com/angelozerr/eclipse-wtp-webresources/blob/master/org.eclipse.a.wst.html.webresources.core/src/org/eclipse/wst/html/webresources/core/utils/DOMHelper.java#L104

It's time to provide an extension point to support that. Please create an issue or PR for that.

gamerson commented 10 years ago

Ok, here is the issue: https://github.com/angelozerr/eclipse-wtp-webresources/issues/9

On Wed, Sep 24, 2014 at 5:18 PM, Angelo notifications@github.com wrote:

Ok, I had not though about this case -(

Today it's hard coded https://github.com/angelozerr/eclipse-wtp-webresources/blob/master/org.eclipse.a.wst.html.webresources.core/src/org/eclipse/wst/html/webresources/core/utils/DOMHelper.java#L104

It's time to provide an extension point to support that. Please create an issue or PR for that.

— Reply to this email directly or view it on GitHub https://github.com/angelozerr/eclipse-wtp-webresources/pull/8#issuecomment-56644761 .

Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com

gamerson commented 10 years ago

I'll try to send a pull later today.

On Wed, Sep 24, 2014 at 5:21 PM, Greg Amerson gregory.amerson@liferay.com wrote:

Ok, here is the issue: https://github.com/angelozerr/eclipse-wtp-webresources/issues/9

On Wed, Sep 24, 2014 at 5:18 PM, Angelo notifications@github.com wrote:

Ok, I had not though about this case -(

Today it's hard coded https://github.com/angelozerr/eclipse-wtp-webresources/blob/master/org.eclipse.a.wst.html.webresources.core/src/org/eclipse/wst/html/webresources/core/utils/DOMHelper.java#L104

It's time to provide an extension point to support that. Please create an issue or PR for that.

— Reply to this email directly or view it on GitHub https://github.com/angelozerr/eclipse-wtp-webresources/pull/8#issuecomment-56644761 .

Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com

Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com