search

angelozerr / eclipse-wtp-webresources

Provides completion, hyperlink, hover inside WTP HTML editor for Web Resources (CSS, JS, Images)
Eclipse Public License 1.0
13 stars 9 forks source link

Allow other DOM attributes to trigger completion #9

Closed gamerson closed 10 years ago

gamerson commented 10 years ago

In alloyui jsp taglibs all css classes are added via the cssClass attribute like

<aui:button cssClass="btn-primary" ... />

It would be good if the webresources plugin had an extension point to allow adopters to add additional attributes that can activate the completion.

angelozerr commented 10 years ago

Ok @gamerson, I will try to provide an extension point to support your case.

angelozerr commented 10 years ago

See https://github.com/angelozerr/eclipse-wtp-webresources/wiki/WebResourcesFinderTypeProvider for more info

gamerson commented 10 years ago

Hey Angelo, this extension point is not working inside jsp documents and jsp tags. It seems that this code in the plugin.xml is not getting called:

https://github.com/angelozerr/eclipse-wtp-webresources/blob/master/org.eclipse.a.wst.html.webresources.ui/plugin.xml#L41-51

On Thu, Sep 25, 2014 at 1:51 AM, Angelo notifications@github.com wrote:

See https://github.com/angelozerr/eclipse-wtp-webresources/wiki/WebResourcesFinderTypeProvider for more info

— Reply to this email directly or view it on GitHub https://github.com/angelozerr/eclipse-wtp-webresources/issues/9#issuecomment-56710963 .

Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com

gamerson commented 10 years ago

Looks like it was missing some partition types, I copied that same set that is used for angularjs computer and now alloy jsp tags are working as expected.

https://github.com/angelozerr/eclipse-wtp-webresources/pull/11

Thanks again, if you merge that pull everything should be working on our end.

On Thu, Sep 25, 2014 at 9:41 AM, Greg Amerson gregory.amerson@liferay.com wrote:

Hey Angelo, this extension point is not working inside jsp documents and jsp tags. It seems that this code in the plugin.xml is not getting called:

https://github.com/angelozerr/eclipse-wtp-webresources/blob/master/org.eclipse.a.wst.html.webresources.ui/plugin.xml#L41-51

On Thu, Sep 25, 2014 at 1:51 AM, Angelo notifications@github.com wrote:

See https://github.com/angelozerr/eclipse-wtp-webresources/wiki/WebResourcesFinderTypeProvider for more info

— Reply to this email directly or view it on GitHub https://github.com/angelozerr/eclipse-wtp-webresources/issues/9#issuecomment-56710963 .

Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com

Greg Amerson Liferay Developer Tools Liferay, Inc. www.liferay.com

gamerson commented 10 years ago

Here is the PR that fixes my issue I just reported

https://github.com/angelozerr/eclipse-wtp-webresources/pull/11

Thanks.