search

angelozerr / jdt-codemining

Eclipse plugin for JDT Java CodeMining
Eclipse Public License 1.0
301 stars 15 forks source link

Use nicer icons for Success and Fail #19

Open vogella opened 6 years ago

vogella commented 6 years ago

I think the current JDT icons are not very nice. I suggest that code mining uses better icons. See https://bugs.eclipse.org/bugs/show_bug.cgi?id=534165 for the reported issue with JDT For example Gradles uses really nice ones.

image

If @angelozerr agrees to better icons I can try to find time to provide a PR for replacing the icons.

angelozerr commented 6 years ago

If @angelozerr agrees to better icons I can try to find time to provide a PR for replacing the icons.

Yes sure!

angelozerr commented 6 years ago

@vogella I'm not sure that it's a good idea, because the icon are the same than JUnit View. IMHO I think we should have the same icon between code mining and JUNit view. If icons must be improved, it should be done for JUNit JDT plugin.