angelozerr / jdt-codemining

Eclipse plugin for JDT Java CodeMining
Eclipse Public License 1.0
298 stars 15 forks source link

Git code mining for methods should list the last modifier #68

Open vogella opened 6 years ago

vogella commented 6 years ago

IMHO the code mining for a method should list the last modifier as most important one. For example, I'm looking at the following method.

@Test
public void testConvertsToBytePrimitive() throws Exception {
    converter = StringToByteConverter.toByte(numberFormat, true);
    Byte value = (byte) 1;
    Byte result = converter.convert(numberFormat.format(value));
    assertEquals(value, result);
}

This method as original developerd by Conrad but later modified by Jens.

IMHO Jens should be listed at the beginning and the time stamp should be last modified.

image

What do you think @thomaswolf?

tomaswolf commented 6 years ago

Would make sense. Would have to be implemented apparently in RevisionAuthorsCodeMining.java and in RevisionRecentChangeCodeMining.java. A user is probably most interested in knowing who touched the code last, and when.

angelozerr commented 6 years ago

Any help are welcome @tomaswolf !